Bug 23781 - Call RenderView::willMoveOffscreen/didMoveOnscreen, and update layers correctly
Summary: Call RenderView::willMoveOffscreen/didMoveOnscreen, and update layers correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 23359
  Show dependency treegraph
 
Reported: 2009-02-05 21:26 PST by Simon Fraser (smfr)
Modified: 2009-02-06 09:05 PST (History)
0 users

See Also:


Attachments
Patch, changelog (3.74 KB, patch)
2009-02-05 22:26 PST, Simon Fraser (smfr)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-02-05 21:26:26 PST
We need to call RenderView::willMoveOffscreen() and didMoveOnscreen() when the document goes in and out of the page cache, so that we hook/unhook layers correctly.

We also need to them in attach/detach, again to hook up the layers.

Finally, we need to update layers in Document::updateRendering().
Comment 1 Simon Fraser (smfr) 2009-02-05 22:26:14 PST
Created attachment 27381 [details]
Patch, changelog
Comment 2 Dave Hyatt 2009-02-05 22:59:29 PST
Comment on attachment 27381 [details]
Patch, changelog

r=me 

Just yank the amusing FIXME from Eric rather than adding to it. :)
Comment 3 Simon Fraser (smfr) 2009-02-06 09:05:16 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/dom/Document.cpp
Committed r40719