Bug 23777

Summary: Make WorkerMessagingProxy class derive from two base proxy classes.
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jianli, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 23776    
Bug Blocks:    
Attachments:
Description Flags
Proposed Patch
none
Proposed Patch
none
Proposed Patch ap: review+

Description Jian Li 2009-02-05 18:46:38 PST
After two base proxy classes are added, we need to make WorkerMessagingProxy class derive from these two base classes.
Comment 1 Jian Li 2009-02-05 19:00:03 PST
Created attachment 27375 [details]
Proposed Patch

This patch is to make WorkerMessagingProxy derive from two base proxy classes introduced in issue 23776. The next patch is to change to use different proxy pointers.
Comment 2 David Levin 2009-02-06 02:35:09 PST
ChangeLog:
  WorkerMessaingProxy sp

These header files seem to be missing from the patch:
  #include "WorkerContextProxyBase.h"
  #include "WorkerObjectProxyBase.h"
Comment 3 David Levin 2009-02-06 02:41:14 PST
I see that have the header files in another patch.  I'd recommend setting the "depends on" field above to make this more clear. 
Comment 4 David Levin 2009-02-06 03:01:23 PST
This looks good to me (just needs the typo fixed in the change log).
Comment 5 Jian Li 2009-02-06 13:24:20 PST
Created attachment 27415 [details]
Proposed Patch
Comment 6 David Levin 2009-02-06 13:25:16 PST
Comment on attachment 27375 [details]
Proposed Patch

new patch obsoletes previous one.
Comment 7 David Levin 2009-02-06 15:18:22 PST
It would be nice to fix the typo:

ChangeLog:
  WorkerMessaingProxy sp
Comment 8 Jian Li 2009-02-06 17:46:05 PST
Created attachment 27442 [details]
Proposed Patch

All fixed. Thanks.
Comment 9 David Levin 2009-02-07 23:03:25 PST
Comment on attachment 27415 [details]
Proposed Patch

New patch makes this one obsolete.
Comment 10 David Levin 2009-02-07 23:09:11 PST
Looks good to me.
Comment 11 Alexey Proskuryakov 2009-02-09 02:09:37 PST
Comment on attachment 27442 [details]
Proposed Patch

r=me. I think that to validate this change, you need to also change the type of Worker::m_messagingProxy though.

         // Only use these methods on the worker object thread.
-        void terminate();
         bool askedToTerminate() const { return m_askedToTerminate; }

There's only one method left here, so the comment needs to be adjusted.
Comment 12 Alexey Proskuryakov 2009-02-09 02:14:14 PST
Committed revision 40781.