Summary: | Make WorkerMessagingProxy class derive from two base proxy classes. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jian Li <jianli> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | jianli, levin | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 23776 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Jian Li
2009-02-05 18:46:38 PST
Created attachment 27375 [details]
Proposed Patch
This patch is to make WorkerMessagingProxy derive from two base proxy classes introduced in issue 23776. The next patch is to change to use different proxy pointers.
ChangeLog: WorkerMessaingProxy sp These header files seem to be missing from the patch: #include "WorkerContextProxyBase.h" #include "WorkerObjectProxyBase.h" I see that have the header files in another patch. I'd recommend setting the "depends on" field above to make this more clear. This looks good to me (just needs the typo fixed in the change log). Created attachment 27415 [details]
Proposed Patch
Comment on attachment 27375 [details]
Proposed Patch
new patch obsoletes previous one.
It would be nice to fix the typo: ChangeLog: WorkerMessaingProxy sp Created attachment 27442 [details]
Proposed Patch
All fixed. Thanks.
Comment on attachment 27415 [details]
Proposed Patch
New patch makes this one obsolete.
Looks good to me. Comment on attachment 27442 [details]
Proposed Patch
r=me. I think that to validate this change, you need to also change the type of Worker::m_messagingProxy though.
// Only use these methods on the worker object thread.
- void terminate();
bool askedToTerminate() const { return m_askedToTerminate; }
There's only one method left here, so the comment needs to be adjusted.
Committed revision 40781. |