Bug 23777 – Make WorkerMessagingProxy class derive from two base proxy classes.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Jian Li]

After two base proxy classes are added, we need to make WorkerMessagingProxy class derive from these two base classes.

[Jian Li]

Created attachment 27375 [details]
Proposed Patch

This patch is to make WorkerMessagingProxy derive from two base proxy classes introduced in issue 23776. The next patch is to change to use different proxy pointers.

[David Levin]

ChangeLog:
  WorkerMessaingProxy sp

These header files seem to be missing from the patch:
  #include "WorkerContextProxyBase.h"
  #include "WorkerObjectProxyBase.h"

[David Levin]

I see that have the header files in another patch.  I'd recommend setting the "depends on" field above to make this more clear. 

[David Levin]

This looks good to me (just needs the typo fixed in the change log).

[Jian Li]

Created attachment 27415 [details]
Proposed Patch

[David Levin]

Comment on attachment 27375 [details]
Proposed Patch

new patch obsoletes previous one.

[David Levin]

It would be nice to fix the typo:

ChangeLog:
  WorkerMessaingProxy sp

[Jian Li]

Created attachment 27442 [details]
Proposed Patch

All fixed. Thanks.

[David Levin]

Comment on attachment 27415 [details]
Proposed Patch

New patch makes this one obsolete.

[David Levin]

Looks good to me.

[Alexey Proskuryakov]

Comment on attachment 27442 [details]
Proposed Patch

r=me. I think that to validate this change, you need to also change the type of Worker::m_messagingProxy though.

         // Only use these methods on the worker object thread.
-        void terminate();
         bool askedToTerminate() const { return m_askedToTerminate; }

There's only one method left here, so the comment needs to be adjusted.

[Alexey Proskuryakov]

Committed revision 40781.