Bug 237745

Summary:

Web Inspector: REGRESSION(r287753): Settings: checkboxes are smaller and no longer vertically align with related text

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akeerthi, ews-watchlist, hi, inspector-bugzilla-changes, nvasilyev, pangle, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

234897

Bug Blocks:

Attachments:

Description	Flags
Patch	none
[Image] With patch applied	none

Description Devin Rousso 2022-03-10 16:24:06 PST

compare ToT with the screenshots on <https://webkit.org/web-inspector/web-inspector-settings/>

Comment 1 Radar WebKit Bug Importer 2022-03-10 16:24:30 PST

<rdar://problem/90129658>

Comment 2 Devin Rousso 2022-03-10 16:26:18 PST

@Aditya Keerthi tells me that it's expected behavior for `font-size` to NOT adjust the sizing of `<input type="checkbox">`, so the following code in `Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css` is no longer valid:
```css
.content-view.tab.settings > .settings-view > .container > .editor-group > .setting-editor input[type="checkbox"] {
    /* Vertically align <select> with the group title text. */
    font-size: 16px;
}
```

Comment 3 Nikita Vasilyev 2022-03-17 15:16:50 PDT

Created attachment 455035 [details]
Patch

Comment 4 Nikita Vasilyev 2022-03-17 15:17:19 PDT

Created attachment 455036 [details]
[Image] With patch applied

Comment 5 Devin Rousso 2022-03-17 20:37:44 PDT

Comment on attachment 455035 [details]
Patch

rs=me

Comment 6 EWS 2022-03-17 21:24:34 PDT

Committed r291466 (248582@main): <https://commits.webkit.org/248582@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455035 [details].