Bug 237745

Summary: Web Inspector: REGRESSION(r287753): Settings: checkboxes are smaller and no longer vertically align with related text
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, ews-watchlist, hi, inspector-bugzilla-changes, nvasilyev, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 234897    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
[Image] With patch applied none

Devin Rousso
Reported 2022-03-10 16:24:06 PST
compare ToT with the screenshots on <https://webkit.org/web-inspector/web-inspector-settings/>
Attachments
Patch (1.70 KB, patch)
2022-03-17 15:16 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] With patch applied (55.25 KB, image/png)
2022-03-17 15:17 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-10 16:24:30 PST
<rdar://problem/90129658>
Devin Rousso
Comment 2 2022-03-10 16:26:18 PST
@Aditya Keerthi tells me that it's expected behavior for `font-size` to NOT adjust the sizing of `<input type="checkbox">`, so the following code in `Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css` is no longer valid: ```css .content-view.tab.settings > .settings-view > .container > .editor-group > .setting-editor input[type="checkbox"] { /* Vertically align <select> with the group title text. */ font-size: 16px; } ```
Nikita Vasilyev
Comment 3 2022-03-17 15:16:50 PDT
Created attachment 455035 [details] Patch
Nikita Vasilyev
Comment 4 2022-03-17 15:17:19 PDT
Created attachment 455036 [details] [Image] With patch applied
Devin Rousso
Comment 5 2022-03-17 20:37:44 PDT
Comment on attachment 455035 [details] Patch rs=me
EWS
Comment 6 2022-03-17 21:24:34 PDT
Committed r291466 (248582@main): <https://commits.webkit.org/248582@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455035 [details].
Note You need to log in before you can comment on or make changes to this bug.