Bug 237734 – Abandoned memory in NetworkStorageManager::m_temporaryBlobPathsByConnection

• Component: Website Storage
• Status: RESOLVED FIXED

[Sihui Liu]

...

[Sihui Liu]

Created attachment 454404 [details]
Patch

[Chris Dumez]

Comment on attachment 454404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454404&action=review

> Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:214
> +            protectedThis->m_temporaryBlobPathsByConnection.remove(connection);

Can't we do this before the work queue dispatch(), instead of re-dispatching to the main thread here?

[Sihui Liu]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 454404 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454404&action=review
> 
> > Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:214
> > +            protectedThis->m_temporaryBlobPathsByConnection.remove(connection);
> 
> Can't we do this before the work queue dispatch(), instead of re-dispatching
> to the main thread here?

This technically should be removed after we notify storage thread; and we need to dispatch to the main thread to deter NetworkStorageManager anyways

[EWS]

Committed r291145 (248305@main): <https://commits.webkit.org/248305@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454404 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90142912>