Bug 237720

Summary: [selection] HTMLTextFormControlElement::subtreeHasChanged() shouldn't be called in setRangeText
Product: WebKit Reporter: zsun
Component: FormsAssignee: zsun
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=223877
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zsun 2022-03-10 09:21:58 PST 
Affected WPT tests:
imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions.html
imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText.html
Comment 1 zsun 2022-03-10 09:32:33 PST 
Created attachment 454372 [details]
Patch
Comment 2 Chris Dumez 2022-03-14 16:29:37 PDT 
Comment on attachment 454372 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454372&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        We shouldn't call HTMLTextFormControlElement::subtreeHasChanged()  in HTMLTextFormControlElement::setRangeText.

nit: extra space before "in"

> Source/WebCore/ChangeLog:11
> +        This cl refers and imports some of the changes in chromiu CL at

I think "cl" is a chrome/blink term.

Also typo: chromiu
Comment 3 zsun 2022-03-15 02:50:00 PDT 
Created attachment 454684 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2022-03-16 05:41:31 PDT 
<rdar://problem/90364922>
Comment 5 zsun 2022-03-17 03:42:17 PDT 
Created attachment 454953 [details]
Patch
Comment 6 zsun 2022-03-21 01:55:47 PDT 
Landing this patch. The test failure in ios-wk2 doesn't seem related to this patch.
Comment 7 EWS 2022-03-21 02:28:16 PDT 
Committed r291555 (248659@main): <https://commits.webkit.org/248659@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454953 [details].