Bug 237704

Summary: Share more code between RemoteRealtimeAudioSource and RemoteRealtimeVideoSource
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 237316    
Bug Blocks: 238449    
Attachments:
Description Flags
WIP
none
Patch
none
Patch none

Description youenn fablet 2022-03-10 04:14:26 PST 
Share more code between RemoteRealtimeAudioSource and RemoteRealtimeVideoSource
Comment 1 youenn fablet 2022-03-10 04:26:33 PST 
Created attachment 454333 [details]
WIP
Comment 2 Radar WebKit Bug Importer 2022-03-17 05:15:18 PDT 
<rdar://problem/90424679>
Comment 3 youenn fablet 2022-03-28 05:25:48 PDT 
Created attachment 455904 [details]
Patch
Comment 4 Eric Carlson 2022-03-28 06:54:45 PDT 
Comment on attachment 455904 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455904&action=review

> Source/WebCore/ChangeLog:9
> +        The remove video source is now correctly exposing whether it is camera, screen...

s/remove/remote/

> Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:81
> +        fprintf(stderr, "RemoteRealtimeMediaSource::createRemoteMediaSource %p %d \n", this, (int) settings.width());

Don't forget to remove this

> Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:107
> +    fprintf(stderr, "RemoteRealtimeMediaSource::setSettings1 %p %d \n", this, (int) m_settings.width());

Ditto

> Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:110
> +    fprintf(stderr, "RemoteRealtimeMediaSource::setSettings2 %p %d \n", this, (int) m_settings.width());

Ditto

> Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:120
> +void RemoteRealtimeMediaSource::hasEnded()

We should change this name, `hasEnded` sounds like it is a getter. Maybe `didEnd` would be better?
Comment 5 youenn fablet 2022-03-28 07:21:11 PDT 
Created attachment 455916 [details]
Patch
Comment 6 EWS 2022-03-28 09:25:22 PDT 
Committed r291967 (248932@main): <https://commits.webkit.org/248932@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455916 [details].