Bug 23769

Summary: Use non-null ResourceError errors.
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
nonnull-errors.patch
none
nonnull-errorsv2.patch ap: review+

Xan Lopez
Reported 2009-02-05 12:57:43 PST
Rather create bogus but non-null errors, since some codepaths expect these. For example, see DocumentLoader::mainReceivedError.
Attachments
nonnull-errors.patch (3.87 KB, patch)
2009-02-05 12:59 PST, Xan Lopez 		no flags
DetailsFormatted DiffDiff
nonnull-errorsv2.patch (3.93 KB, patch)
2009-02-05 14:24 PST, Xan Lopez 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2009-02-05 12:59:09 PST
Created attachment 27359 [details] nonnull-errors.patch
Alexey Proskuryakov
Comment 2 2009-02-05 14:17:37 PST
Comment on attachment 27359 [details] nonnull-errors.patch I think it would be nice and easy to make cancelledError return a cancellation - like it is done in emptyClients.
Xan Lopez
Comment 3 2009-02-05 14:24:04 PST
Created attachment 27363 [details] nonnull-errorsv2.patch
Alexey Proskuryakov
Comment 4 2009-02-06 02:08:54 PST
Comment on attachment 27363 [details] nonnull-errorsv2.patch r=me
Alexey Proskuryakov
Comment 5 2009-02-06 02:10:32 PST
Committed revision 40716.
Note You need to log in before you can comment on or make changes to this bug.