Bug 23769

Summary:

Use non-null ResourceError errors.

Product:

WebKit

Reporter:

Xan Lopez <xan.lopez>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
nonnull-errors.patch	none
nonnull-errorsv2.patch	ap: review+

Description Xan Lopez 2009-02-05 12:57:43 PST

Rather create bogus but non-null errors, since some codepaths expect these. For example, see DocumentLoader::mainReceivedError.

Comment 1 Xan Lopez 2009-02-05 12:59:09 PST

Created attachment 27359 [details]
nonnull-errors.patch

Comment 2 Alexey Proskuryakov 2009-02-05 14:17:37 PST

Comment on attachment 27359 [details]
nonnull-errors.patch

I think it would be nice and easy to make cancelledError return a cancellation - like it is done in emptyClients.

Comment 3 Xan Lopez 2009-02-05 14:24:04 PST

Created attachment 27363 [details]
nonnull-errorsv2.patch

Comment 4 Alexey Proskuryakov 2009-02-06 02:08:54 PST

Comment on attachment 27363 [details]
nonnull-errorsv2.patch

r=me

Comment 5 Alexey Proskuryakov 2009-02-06 02:10:32 PST

Committed revision 40716.