Bug 237681

Summary: [Flatpak SDK] Include gi-docgen and its dependencies
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 226662    
Attachments:
Description Flags
Patch
none
Patch none

Adrian Perez
Reported 2022-03-09 15:10:14 PST
As part of the work for bug #226662 we will want to have gi-docgen in the SDK, to make developer builds check whether documentation is complete :]
Attachments
Patch (3.17 KB, patch)
2022-03-18 09:30 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch (3.95 KB, patch)
2022-03-19 16:11 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2022-03-18 09:30:04 PDT
Created attachment 455100 [details] Patch
Adrian Perez
Comment 2 2022-03-19 14:22:39 PDT
Comment on attachment 455100 [details] Patch Setting cq-, after building the SDK locally and giving it a go, it turns out that gi-docgen also uses python-smartypants — gotta add that one, too!
Adrian Perez
Comment 3 2022-03-19 16:11:52 PDT
Created attachment 455181 [details] Patch Now with the (previously missing) smartypants Python package.
EWS
Comment 4 2022-03-20 04:47:30 PDT
Committed r291542 (248648@main): <https://commits.webkit.org/248648@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455181 [details].
Radar WebKit Bug Importer
Comment 5 2022-03-20 04:48:16 PDT
<rdar://problem/90536925>
Note You need to log in before you can comment on or make changes to this bug.