Bug 237668

Summary: [CMake] Associate platform specific configuration with WinCairo
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, Basuke.Suzuki, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Don Olmstead 2022-03-09 10:21:07 PST 
Some is in the root source listing some is under WinCairo check. Just make it all under WinCairo.
Comment 1 Don Olmstead 2022-03-09 10:33:12 PST 
Created attachment 454266 [details]
Patch
Comment 2 Basuke Suzuki 2022-03-09 10:36:59 PST 
Comment on attachment 454266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review

> Source/WebKit/PlatformWin.cmake:-170
> -

Is it okay to remove these definitions?
Comment 3 Don Olmstead 2022-03-09 10:38:21 PST 
Comment on attachment 454266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review

>> Source/WebKit/PlatformWin.cmake:-170
>> -
> 
> Is it okay to remove these definitions?

Yea they're in the cmakeconfig.h and using `add_definitions` is frowned upon for modern CMake code anyways.
Comment 4 Basuke Suzuki 2022-03-09 10:39:14 PST 
Comment on attachment 454266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454266&action=review

>>> Source/WebKit/PlatformWin.cmake:-170
>>> -
>> 
>> Is it okay to remove these definitions?
> 
> Yea they're in the cmakeconfig.h and using `add_definitions` is frowned upon for modern CMake code anyways.

Great.
Comment 5 EWS 2022-03-09 12:45:50 PST 
Committed r291061 (248234@main): <https://commits.webkit.org/248234@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454266 [details].