Bug 237661

Summary: [web-animations] font-variant-alternates should support discrete animation
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mmaxfield: review+

Description Antoine Quint 2022-03-09 09:40:38 PST 
[web-animations] font-variant-alternates should support discrete animation
Comment 1 Antoine Quint 2022-03-09 09:42:00 PST 
Created attachment 454251 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-03-09 11:29:36 PST 
Comment on attachment 454251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454251&action=review

> Source/WebCore/rendering/style/RenderStyle.h:376
> +    FontVariantAlternates fontVariantAlternates() const { return fontDescription().variantAlternates(); }

Do we need to fix RenderStyle::diff() for this?
Comment 3 Myles C. Maxfield 2022-03-09 16:51:39 PST 
Comment on attachment 454251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454251&action=review

>> Source/WebCore/rendering/style/RenderStyle.h:376
>> +    FontVariantAlternates fontVariantAlternates() const { return fontDescription().variantAlternates(); }
> 
> Do we need to fix RenderStyle::diff() for this?

No. It's handled by FontDescription::operator==().
Comment 4 Antoine Quint 2022-03-10 04:50:15 PST 
Committed r291104 (248266@trunk): <https://commits.webkit.org/248266@trunk>
Comment 5 Radar WebKit Bug Importer 2022-03-10 04:51:16 PST 
<rdar://problem/90091977>