Bug 237661

Summary: [web-animations] font-variant-alternates should support discrete animation
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mmaxfield: review+

Antoine Quint
Reported 2022-03-09 09:40:38 PST
[web-animations] font-variant-alternates should support discrete animation
Attachments
Patch (12.21 KB, patch)
2022-03-09 09:42 PST, Antoine Quint 		mmaxfield: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2022-03-09 09:42:00 PST
Created attachment 454251 [details] Patch
Simon Fraser (smfr)
Comment 2 2022-03-09 11:29:36 PST
Comment on attachment 454251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454251&action=review > Source/WebCore/rendering/style/RenderStyle.h:376 > + FontVariantAlternates fontVariantAlternates() const { return fontDescription().variantAlternates(); } Do we need to fix RenderStyle::diff() for this?
Myles C. Maxfield
Comment 3 2022-03-09 16:51:39 PST
Comment on attachment 454251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454251&action=review >> Source/WebCore/rendering/style/RenderStyle.h:376 >> + FontVariantAlternates fontVariantAlternates() const { return fontDescription().variantAlternates(); } > > Do we need to fix RenderStyle::diff() for this? No. It's handled by FontDescription::operator==().
Antoine Quint
Comment 4 2022-03-10 04:50:15 PST
Committed r291104 (248266@trunk): <https://commits.webkit.org/248266@trunk>
Radar WebKit Bug Importer
Comment 5 2022-03-10 04:51:16 PST
<rdar://problem/90091977>
Note You need to log in before you can comment on or make changes to this bug.