Bug 237651

Summary: [web-animations] increase the max number of animatable properties
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, graouts, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Description Antoine Quint 2022-03-09 05:27:20 PST 
[web-animations] increase the max number of animatable properties
Comment 1 Antoine Quint 2022-03-09 05:28:09 PST 
Created attachment 454230 [details]
Patch
Comment 2 Antti Koivisto 2022-03-09 05:29:57 PST 
Comment on attachment 454230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454230&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:2896
> +    COMPILE_ASSERT(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount < USHRT_MAX, numberOfAnimatablePropertiesMustBeLessThanUShrtMax);

more modern C++ would say std::numeric_limits<unsigned short>::max()
Comment 3 Antoine Quint 2022-03-09 05:44:34 PST 
Committed r291047 (248221@trunk): <https://commits.webkit.org/248221@trunk>
Comment 4 Antoine Quint 2022-03-09 05:45:10 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 454230 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454230&action=review
> 
> > Source/WebCore/animation/CSSPropertyAnimation.cpp:2896
> > +    COMPILE_ASSERT(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount < USHRT_MAX, numberOfAnimatablePropertiesMustBeLessThanUShrtMax);
> 
> more modern C++ would say std::numeric_limits<unsigned short>::max()

Used that in the commit. Thank you!
Comment 5 Radar WebKit Bug Importer 2022-03-09 05:45:17 PST 
<rdar://problem/90026878>