Bug 237650

Summary: [web-animations] font-synthesis should support discrete animation
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mmaxfield: review+, ews-feeder: commit-queue-

Antoine Quint
Reported 2022-03-09 04:30:37 PST
[web-animations] font-synthesis should support discrete animation
Attachments
Patch (9.45 KB, patch)
2022-03-09 04:30 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (9.61 KB, patch)
2022-03-09 11:17 PST, Antoine Quint 		mmaxfield: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2022-03-09 04:30:58 PST
Created attachment 454228 [details] Patch
Antoine Quint
Comment 2 2022-03-09 11:17:46 PST
Created attachment 454271 [details] Patch
Simon Fraser (smfr)
Comment 3 2022-03-09 11:29:02 PST
Comment on attachment 454271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454271&action=review > Source/WebCore/rendering/style/RenderStyle.h:376 > + FontSynthesis fontSynthesis() const { return fontDescription().fontSynthesis(); } Do we need to fix RenderStyle::diff() for this too?
Myles C. Maxfield
Comment 4 2022-03-09 16:50:42 PST
Comment on attachment 454271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454271&action=review >> Source/WebCore/rendering/style/RenderStyle.h:376 >> + FontSynthesis fontSynthesis() const { return fontDescription().fontSynthesis(); } > > Do we need to fix RenderStyle::diff() for this too? No. This is handled by FontDescription::operator==().
Antoine Quint
Comment 5 2022-03-10 04:45:07 PST
Committed r291103 (248265@trunk): <https://commits.webkit.org/248265@trunk>
Radar WebKit Bug Importer
Comment 6 2022-03-10 04:46:17 PST
<rdar://problem/90091827>
Note You need to log in before you can comment on or make changes to this bug.