Bug 237650

Summary:

[web-animations] font-synthesis should support discrete animation

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, dino, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar, WebExposed, WPTImpact

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mmaxfield: review+, ews-feeder: commit-queue-

Description Antoine Quint 2022-03-09 04:30:37 PST

[web-animations] font-synthesis should support discrete animation

Comment 1 Antoine Quint 2022-03-09 04:30:58 PST

Created attachment 454228 [details]
Patch

Comment 2 Antoine Quint 2022-03-09 11:17:46 PST

Created attachment 454271 [details]
Patch

Comment 3 Simon Fraser (smfr) 2022-03-09 11:29:02 PST

Comment on attachment 454271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454271&action=review

> Source/WebCore/rendering/style/RenderStyle.h:376
> +    FontSynthesis fontSynthesis() const { return fontDescription().fontSynthesis(); }

Do we need to fix RenderStyle::diff() for this too?

Comment 4 Myles C. Maxfield 2022-03-09 16:50:42 PST

Comment on attachment 454271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454271&action=review

>> Source/WebCore/rendering/style/RenderStyle.h:376
>> +    FontSynthesis fontSynthesis() const { return fontDescription().fontSynthesis(); }
> 
> Do we need to fix RenderStyle::diff() for this too?

No. This is handled by FontDescription::operator==().

Comment 5 Antoine Quint 2022-03-10 04:45:07 PST

Committed r291103 (248265@trunk): <https://commits.webkit.org/248265@trunk>

Comment 6 Radar WebKit Bug Importer 2022-03-10 04:46:17 PST

<rdar://problem/90091827>