Bug 237641

Summary: [Selection] Fixes selection range settings for TEXTAREA
Product: WebKit Reporter: zsun
Component: FormsAssignee: zsun
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dpino, esprehn+autocc, ews-watchlist, gyuyoung.kim, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

zsun
Reported 2022-03-09 02:59:45 PST
A few WPT tests in imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection are affected.
Attachments
Patch (38.94 KB, patch)
2022-03-09 03:18 PST, zsun 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (39.00 KB, patch)
2022-03-09 08:01 PST, zsun 		no flags
DetailsFormatted DiffDiff
Patch (41.12 KB, patch)
2022-03-09 10:44 PST, zsun 		no flags
DetailsFormatted DiffDiff
Patch (45.68 KB, patch)
2022-03-10 01:07 PST, zsun 		no flags
DetailsFormatted DiffDiff
Patch (49.14 KB, patch)
2022-03-14 04:38 PDT, zsun 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (49.14 KB, patch)
2022-03-14 04:59 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (49.12 KB, patch)
2022-03-15 02:41 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
zsun
Comment 1 2022-03-09 03:18:03 PST
Created attachment 454220 [details] Patch
zsun
Comment 2 2022-03-09 08:01:57 PST
Created attachment 454237 [details] Patch
zsun
Comment 3 2022-03-09 10:44:14 PST
Created attachment 454269 [details] Patch
zsun
Comment 4 2022-03-10 01:07:02 PST
Created attachment 454322 [details] Patch
zsun
Comment 5 2022-03-14 04:38:12 PDT
Created attachment 454579 [details] Patch
zsun
Comment 6 2022-03-14 04:59:34 PDT
Created attachment 454581 [details] Patch
Radar WebKit Bug Importer
Comment 7 2022-03-14 08:56:19 PDT
<rdar://problem/90248608>
Chris Dumez
Comment 8 2022-03-14 16:32:58 PDT
Comment on attachment 454581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454581&action=review r=me > Source/WebCore/html/HTMLTextFormControlElement.cpp:316 > + RefPtr<Frame> frame = document().frame(); RefPtr frame = document().frame(); > Source/WebCore/html/TextFieldInputType.cpp:148 > + unsigned max = visibleValue().length(); nit: I would use auto.
zsun
Comment 9 2022-03-15 02:41:13 PDT
Created attachment 454682 [details] Patch
EWS
Comment 10 2022-03-17 02:20:40 PDT
Committed r291396 (248526@main): <https://commits.webkit.org/248526@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454682 [details].
Arcady Goldmints-Orlov
Comment 11 2022-04-28 20:29:25 PDT
*** Bug 207624 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.