Bug 237592

Summary: Remove RemoteVideoSample
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2022-03-08 03:02:20 PST
Remove RemoteVideoSample
Attachments
Patch (42.01 KB, patch)
2022-03-08 03:04 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (42.00 KB, patch)
2022-03-08 04:16 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (44.44 KB, patch)
2022-03-08 08:40 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (44.59 KB, patch)
2022-03-08 08:46 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (37.79 KB, patch)
2022-03-09 23:06 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-03-08 03:04:25 PST
Created attachment 454091 [details] Patch
youenn fablet
Comment 2 2022-03-08 04:16:55 PST
Created attachment 454100 [details] Patch
Eric Carlson
Comment 3 2022-03-08 08:10:12 PST
Comment on attachment 454100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454100&action=review > Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:110 > + connection->send(Messages::LibWebRTCCodecs::CompletedDecodingCV { identifier, timeStamp, pixelBuffer, MediaTime(timeStampNs, 1) }, 0); I see this isn't new, but do you mean to create a MediaTime with a timescale of 1?
youenn fablet
Comment 4 2022-03-08 08:40:52 PST
Created attachment 454125 [details] Patch
youenn fablet
Comment 5 2022-03-08 08:46:26 PST
Created attachment 454126 [details] Patch
youenn fablet
Comment 6 2022-03-08 08:49:29 PST
(In reply to Eric Carlson from comment #3) > Comment on attachment 454100 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454100&action=review > > > Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:110 > > + connection->send(Messages::LibWebRTCCodecs::CompletedDecodingCV { identifier, timeStamp, pixelBuffer, MediaTime(timeStampNs, 1) }, 0); > > I see this isn't new, but do you mean to create a MediaTime with a timescale > of 1? Good point, fixing it in the latest patch.
EWS
Comment 7 2022-03-09 11:22:39 PST
Tools/Scripts/svn-apply failed to apply attachment 454126 [details] to trunk. Please resolve the conflicts and upload a new patch.
youenn fablet
Comment 8 2022-03-09 23:06:02 PST
Created attachment 454319 [details] Patch for landing
EWS
Comment 9 2022-03-10 01:09:10 PST
Committed r291095 (248257@main): <https://commits.webkit.org/248257@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454319 [details].
Radar WebKit Bug Importer
Comment 10 2022-03-10 01:10:17 PST
<rdar://problem/90085513>
Note You need to log in before you can comment on or make changes to this bug.