| Summary: | Remove RemoteVideoSample | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | annulen, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
youenn fablet
2022-03-08 03:02:20 PST
Created attachment 454091 [details]
Patch
Created attachment 454100 [details]
Patch
Comment on attachment 454100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454100&action=review > Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:110 > + connection->send(Messages::LibWebRTCCodecs::CompletedDecodingCV { identifier, timeStamp, pixelBuffer, MediaTime(timeStampNs, 1) }, 0); I see this isn't new, but do you mean to create a MediaTime with a timescale of 1? Created attachment 454125 [details]
Patch
Created attachment 454126 [details]
Patch
(In reply to Eric Carlson from comment #3) > Comment on attachment 454100 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454100&action=review > > > Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:110 > > + connection->send(Messages::LibWebRTCCodecs::CompletedDecodingCV { identifier, timeStamp, pixelBuffer, MediaTime(timeStampNs, 1) }, 0); > > I see this isn't new, but do you mean to create a MediaTime with a timescale > of 1? Good point, fixing it in the latest patch. Tools/Scripts/svn-apply failed to apply attachment 454126 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 454319 [details]
Patch for landing
Committed r291095 (248257@main): <https://commits.webkit.org/248257@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454319 [details]. |