Bug 237556

Summary: Fix Release builds for sanitizers by defining RELEASE_WITHOUT_OPTIMIZATIONS
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: katherine_cheney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2022-03-07 14:13:40 PST
Fix Release builds for sanitizers by defining RELEASE_WITHOUT_OPTIMIZATIONS. If this is not defined, errors like this occur when building Release with lower optimization levels: Source/WTF/wtf/Compiler.h:103:2: error: "Building release without compiler optimizations: WebKit will be slow. Set -DRELEASE_WITHOUT_OPTIMIZATIONS if this is intended."
Attachments
Patch v1 (1.73 KB, patch)
2022-03-07 14:15 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-07 14:13:57 PST
<rdar://problem/89929061>
David Kilzer (:ddkilzer)
Comment 2 2022-03-07 14:15:11 PST
Created attachment 454034 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2022-03-07 16:40:45 PST
Comment on attachment 454034 [details] Patch v1 cq+ since this doesn't affect non-sanitizer builds.
EWS
Comment 4 2022-03-07 19:01:52 PST
Committed r290970 (248149@main): <https://commits.webkit.org/248149@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454034 [details].
Note You need to log in before you can comment on or make changes to this bug.