Bug 237550

Summary: WebSocket requests should include Sec-Fetch-Mode=websocket for FetchMetadata
Product: WebKit Reporter: Patrick Griffis <pgriffis>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: annevk, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204744
Bug Depends on: 247696    
Bug Blocks: 246508    
Attachments:
Description Flags
Test case ews-feeder: commit-queue-

Description Patrick Griffis 2022-03-07 13:00:33 PST 
As part of the FetchMetadata spec they don't use the normal request modes they have a distinct one.

I plan on working on this soon.
Comment 1 Radar WebKit Bug Importer 2022-03-10 10:22:16 PST 
<rdar://problem/90106854>
Comment 2 Patrick Griffis 2022-03-29 11:03:08 PDT 
Created attachment 456044 [details]
Test case
Comment 3 Patrick Griffis 2022-03-29 11:04:16 PDT 
Attached is a test case for this, however running it Chromium does not attach any metadata to the websocket handshake request, the same as our current behavior. Firefox *does* attach metadata for this so there is an inconsistency there.
Comment 4 Anne van Kesteren 2022-10-14 01:24:27 PDT 
Per Fetch they should be included. The handshake goes through the normal fetch algorithm after all and there's no special casing for setting these request headers.
Comment 5 youenn fablet 2022-11-09 03:37:29 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6296
Comment 6 EWS 2022-11-10 04:25:42 PST 
Committed 256527@main (f05061a1e830): <https://commits.webkit.org/256527@main>

Reviewed commits have been landed. Closing PR #6296 and removing active labels.