Bug 237521

Summary: makeprop.pl breaks reproducible builds
Product: WebKit Reporter: Alberto Garcia <berto>
Component: CSSAssignee: Alberto Garcia <berto>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, cgarcia, emw, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=242457
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Alberto Garcia
Reported 2022-03-07 03:33:11 PST
I'm trying to make the WebKit build reproducible, and one problem that I've found is that the CSSPropertyNames.cpp file generated by makeprop.pl is different in each build. The reason is the way makeprop.pl iterates over the contents of hashes, which by definition are not guaranteed to have a stable order in Perl. Fortunately this is easy to solve, I'm uploading a patch.
Attachments
Patch (4.71 KB, patch)
2022-03-07 03:41 PST, Alberto Garcia 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2022-03-07 03:41:42 PST
Created attachment 453959 [details] Patch
EWS
Comment 2 2022-03-07 04:44:44 PST
Committed r290883 (248114@main): <https://commits.webkit.org/248114@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453959 [details].
Radar WebKit Bug Importer
Comment 3 2022-03-07 04:45:16 PST
<rdar://problem/89899805>
Note You need to log in before you can comment on or make changes to this bug.