| Summary: | Remove unnecessary Async attribute in .messages.in files | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, cgarcia, eric.carlson, ews-watchlist, glenn, hi, jer.noble, joepeck, pangle, pascoe, philipj, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2022-03-04 18:12:07 PST
Created attachment 453885 [details]
Patch
Comment on attachment 453885 [details]
Patch
r- because EWS failures look real.
Created attachment 453996 [details]
Patch
Created attachment 454004 [details]
Patch
The test expectations change because there are some test messages.in files that contained unannotated messages with replies, such as TestWithLegacyReceiver.CreatePlugin, which were assumed to be synchronous and now are assumed to be async. I programmatically verified that no non-test message receivers were like this, and I verified that the output is binary equal before and after this change. Comment on attachment 454004 [details]
Patch
r=me assuming the bots are happy.
Committed r290903 (248134@main): <https://commits.webkit.org/248134@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454004 [details]. |