Bug 237491

Summary: Remove unnecessary Async attribute in .messages.in files
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, eric.carlson, ews-watchlist, glenn, hi, jer.noble, joepeck, pangle, pascoe, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2022-03-04 18:12:07 PST
Remove unnecessary Async attribute in .messages.in files
Attachments
Patch (218.68 KB, patch)
2022-03-04 18:13 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (218.58 KB, patch)
2022-03-07 09:39 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (299.04 KB, patch)
2022-03-07 11:08 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-03-04 18:13:01 PST
Created attachment 453885 [details] Patch
Chris Dumez
Comment 2 2022-03-04 22:04:31 PST
Comment on attachment 453885 [details] Patch r- because EWS failures look real.
Alex Christensen
Comment 3 2022-03-07 09:39:30 PST
Created attachment 453996 [details] Patch
Alex Christensen
Comment 4 2022-03-07 11:08:45 PST
Created attachment 454004 [details] Patch
Alex Christensen
Comment 5 2022-03-07 11:34:31 PST
The test expectations change because there are some test messages.in files that contained unannotated messages with replies, such as TestWithLegacyReceiver.CreatePlugin, which were assumed to be synchronous and now are assumed to be async. I programmatically verified that no non-test message receivers were like this, and I verified that the output is binary equal before and after this change.
Chris Dumez
Comment 6 2022-03-07 12:12:46 PST
Comment on attachment 454004 [details] Patch r=me assuming the bots are happy.
EWS
Comment 7 2022-03-07 13:00:16 PST
Committed r290903 (248134@main): <https://commits.webkit.org/248134@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454004 [details].
Radar WebKit Bug Importer
Comment 8 2022-03-07 13:01:18 PST
<rdar://problem/89924967>
Note You need to log in before you can comment on or make changes to this bug.