Bug 237455

Summary: IDB serialization thread should pass isolated copy of IndexIDToIndexKeyMap to storage thread
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: WebCore Misc.Assignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, ews-watchlist, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Sihui Liu
Reported 2022-03-03 15:53:40 PST
...
Attachments
Patch (2.78 KB, patch)
2022-03-03 15:56 PST, Sihui Liu 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.10 KB, patch)
2022-03-03 17:07 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.06 KB, patch)
2022-03-04 08:50 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2022-03-03 15:56:43 PST
Created attachment 453792 [details] Patch
Sihui Liu
Comment 2 2022-03-03 17:07:48 PST
Created attachment 453798 [details] Patch
Chris Dumez
Comment 3 2022-03-04 08:34:28 PST
Comment on attachment 453798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453798&action=review r=me with improvement suggestion > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:506 > + indexKeys.add(entry.key, indexKey.isolatedCopy()); I recommend `WTFMove(indexKey).isolatedCopy()`. A lot of types (like String) have special optimizations when isolatedCopy() is called on a r-value expression.
Sihui Liu
Comment 4 2022-03-04 08:47:35 PST
(In reply to Chris Dumez from comment #3) > Comment on attachment 453798 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453798&action=review > > r=me with improvement suggestion > > > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:506 > > + indexKeys.add(entry.key, indexKey.isolatedCopy()); > > I recommend `WTFMove(indexKey).isolatedCopy()`. A lot of types (like String) > have special optimizations when isolatedCopy() is called on a r-value > expression. Sure, will change.
Sihui Liu
Comment 5 2022-03-04 08:50:05 PST
Created attachment 453848 [details] Patch for landing
EWS
Comment 6 2022-03-04 10:04:44 PST
Committed r290836 (248072@main): <https://commits.webkit.org/248072@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453848 [details].
Radar WebKit Bug Importer
Comment 7 2022-03-04 10:05:17 PST
<rdar://problem/89820257>
Note You need to log in before you can comment on or make changes to this bug.