Bug 237444

Summary: Push HTMLMediaElement renderer's contentBox rect to GPU process
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing ews-feeder: commit-queue-

Eric Carlson
Reported 2022-03-03 12:44:21 PST
The platform media player needs to know the render's content rect so size the video layer correctly
Attachments
Patch (16.79 KB, patch)
2022-03-03 12:58 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.82 KB, patch)
2022-03-03 17:35 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.82 KB, patch)
2022-03-06 08:23 PST, Eric Carlson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2022-03-03 12:44:53 PST
rdar://84869202
Eric Carlson
Comment 2 2022-03-03 12:58:45 PST
Created attachment 453780 [details] Patch
Jer Noble
Comment 3 2022-03-03 17:17:54 PST
Comment on attachment 453780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453780&action=review > Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:84 > + ALWAYS_LOG(LOGIDENTIFIER); Can we ALWAYS_LOG the size here as well?
Eric Carlson
Comment 4 2022-03-03 17:35:17 PST
Created attachment 453803 [details] Patch for landing
EWS
Comment 5 2022-03-04 10:02:47 PST
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Eric Carlson
Comment 6 2022-03-06 08:23:22 PST
Created attachment 453931 [details] Patch for landing
EWS
Comment 7 2022-03-06 09:29:34 PST
Committed r290874 (248105@main): <https://commits.webkit.org/248105@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453931 [details].
Note You need to log in before you can comment on or make changes to this bug.