Bug 237441

Summary:

Fix broken SuspendExceptionScope and remove redundant VM::DeferExceptionScope.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, hi, joepeck, keith_miller, msaboff, pangle, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	none
proposed patch.	none
proposed patch.	none

Mark Lam

Reported 2022-03-03 12:03:21 PST

SuspendExceptionScope was meant to do exactly the same things that VM::DeferExceptionScope does, except that SuspendExceptionScope hasn't been updated to handle exception handling via VMtraps bits. This patch will fix SuspendExceptionScope to work like VM::DeferExceptionScope, and remove the now redundant VM::DeferExceptionScope. SuspendExceptionScope is the better name here because the scope actually suspends any pending exception. This is different from other Defer scopes where we prevent some new event from arising and defer the event to a later time.

Attachments
proposed patch. (10.67 KB, patch) 2022-03-03 12:10 PST, Mark Lam	no flags	Details Formatted Diff Diff
proposed patch. (10.67 KB, patch) 2022-03-03 12:13 PST, Mark Lam	no flags	Details Formatted Diff Diff
proposed patch. (10.67 KB, patch) 2022-03-03 12:15 PST, Mark Lam	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.