Bug 237441

Summary: Fix broken SuspendExceptionScope and remove redundant VM::DeferExceptionScope.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, joepeck, keith_miller, msaboff, pangle, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch.
none
proposed patch. none

Description Mark Lam 2022-03-03 12:03:21 PST 
SuspendExceptionScope was meant to do exactly the same things that VM::DeferExceptionScope does, except that SuspendExceptionScope hasn't been updated to handle exception handling via VMtraps bits.  This patch will fix SuspendExceptionScope to work like VM::DeferExceptionScope, and remove the now redundant VM::DeferExceptionScope.  SuspendExceptionScope is the better name here because the scope actually suspends any pending exception.  This is different from other Defer scopes where we prevent some new event from arising and defer the event to a later time.
Comment 1 Radar WebKit Bug Importer 2022-03-03 12:03:58 PST 
<rdar://problem/89769627>
Comment 2 Mark Lam 2022-03-03 12:10:24 PST 
Created attachment 453775 [details]
proposed patch.
Comment 3 Mark Lam 2022-03-03 12:13:55 PST 
Created attachment 453777 [details]
proposed patch.
Comment 4 Mark Lam 2022-03-03 12:15:29 PST 
Created attachment 453778 [details]
proposed patch.
Comment 5 Yusuke Suzuki 2022-03-03 13:09:57 PST 
Comment on attachment 453778 [details]
proposed patch.

r=me
Comment 6 Mark Lam 2022-03-05 10:19:31 PST 
Comment on attachment 453778 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 7 EWS 2022-03-05 10:56:28 PST 
Committed r290869 (248100@main): <https://commits.webkit.org/248100@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453778 [details].