Bug 237407

Summary: [iOS] Unable to scroll to a found text range when there is an existing selection
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: New BugsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, katherine_cheney, megan_gardner, mifenton, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
wenson_hsieh: review+
Patch for landing ews-feeder: commit-queue-

Description Aditya Keerthi 2022-03-02 22:00:23 PST 
...
Comment 1 Aditya Keerthi 2022-03-02 22:00:39 PST 
rdar://89653213
Comment 2 Aditya Keerthi 2022-03-02 22:02:53 PST 
Created attachment 453696 [details]
Patch
Comment 3 Wenson Hsieh 2022-03-03 09:31:09 PST 
Comment on attachment 453696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453696&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:600
> +    TestWebKitAPI::Util::run(&scrollViewDelegate.get()->_finishedScrolling);

Nit - I think you can remove the `.get()` here.
Comment 4 Aditya Keerthi 2022-03-03 10:58:19 PST 
Created attachment 453761 [details]
Patch for landing
Comment 5 Aditya Keerthi 2022-03-03 10:59:25 PST 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 453696 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453696&action=review

Thanks for the review!

> > Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:600
> > +    TestWebKitAPI::Util::run(&scrollViewDelegate.get()->_finishedScrolling);
> 
> Nit - I think you can remove the `.get()` here.

Removed.
Comment 6 EWS 2022-03-04 09:18:26 PST 
Committed r290834 (248070@main): <https://commits.webkit.org/248070@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453761 [details].