Bug 237406

Summary: [Style] Forbid spaces between type names and protocol names in Objective-C
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Myles C. Maxfield
Reported 2022-03-02 20:34:19 PST
[Style] Forbid spaces between type names and protocol names in Objective-C
Attachments
Patch (4.70 KB, patch)
2022-03-02 20:36 PST, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-03-02 20:36:13 PST
Created attachment 453694 [details] Patch
Darin Adler
Comment 2 2022-03-03 08:10:37 PST
Comment on attachment 453694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453694&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:3420 > + using_space_with_protocol = search(r'\Wid <', line) Is \W better than \b for this?
Myles C. Maxfield
Comment 3 2022-03-03 08:57:08 PST
Comment on attachment 453694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453694&action=review >> Tools/Scripts/webkitpy/style/checkers/cpp.py:3420 >> + using_space_with_protocol = search(r'\Wid <', line) > > Is \W better than \b for this? \b is probably better. I’ll update before landing.
Myles C. Maxfield
Comment 4 2022-03-03 10:21:14 PST
Committed r290784 (248028@trunk): <https://commits.webkit.org/248028@trunk>
Radar WebKit Bug Importer
Comment 5 2022-03-03 10:22:17 PST
<rdar://problem/89762953>
Note You need to log in before you can comment on or make changes to this bug.