Bug 237390

Summary: [AppSSO] Correct logging messages to avoid confusing screeners that an error has occurred
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, pascoe, sacolo9459, simon.fraser, webkit-bug-importer, yivarak978
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2022-03-02 13:50:17 PST
The phrasing of the message in 'SOAuthorizationCoordinator::tryAuthorize' when a URL is not relevant for AppSSO flows is: AUTHORIZATIONCOORDINATOR_RELEASE_LOG("tryAuthorize: Cannot authorize the requested URL."); This leads people spelunking logs to believe that the URL can't be authorized (perhaps due to an error). Instead, we should more accurately report that the URL is not one that is mediated through an AppSSO flow, and so no AppSSO processing is needed.
Attachments
Patch (4.82 KB, patch)
2022-03-02 14:02 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-02 13:51:49 PST
<rdar://problem/89710486>
Brent Fulgham
Comment 2 2022-03-02 14:02:08 PST
Created attachment 453657 [details] Patch
EWS
Comment 3 2022-03-02 15:26:26 PST
Committed r290758 (248002@main): <https://commits.webkit.org/248002@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453657 [details].
Note You need to log in before you can comment on or make changes to this bug.