Bug 237379

Summary: rdar://89579689: Define DEPLOYMENT_TARGET_CLANG_ENV_NAME in the legacy build system
Product: WebKit Reporter: Elliott Williams <emw>
Component: New BugsAssignee: Elliott Williams <emw>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ap, eric.carlson, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Elliott Williams
Reported 2022-03-02 11:01:11 PST
rdar://89579689: Define DEPLOYMENT_TARGET_CLANG_ENV_NAME in the legacy build system
Attachments
Patch (14.14 KB, patch)
2022-03-02 11:05 PST, Elliott Williams 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Elliott Williams
Comment 1 2022-03-02 11:01:52 PST
rdar://89579689
Elliott Williams
Comment 2 2022-03-02 11:05:00 PST
Created attachment 453639 [details] Patch
Elliott Williams
Comment 3 2022-03-02 11:05:03 PST
<rdar://problem/89579689>
Alexey Proskuryakov
Comment 4 2022-03-02 11:08:05 PST
Comment on attachment 453639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453639&action=review > Source/WTF/Configurations/Base.xcconfig:116 > +DEPLOYMENT_TARGET_CLANG_ENV_NAME_legacy[sdk=watch*] = WATCHOS_DEPLOYMENT_TARGET; Don't we need tvOS all over the place? I also wonder if a temporary hack in HaveInternalSDK.xcconfig would be better than having this all over the place.
Elliott Williams
Comment 5 2022-03-02 11:38:02 PST
Good idea. Let's hack in HaveInternalSDK.xcconfig, as this is an internal-only Xcode bug.
Note You need to log in before you can comment on or make changes to this bug.