Summary: | [web-animations] changes to font-size should recompute keyframes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dino, graouts, koivisto, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar, WebExposed, WPTImpact | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Antoine Quint
2022-03-02 01:37:29 PST
Created attachment 453580 [details]
Patch
Created attachment 453581 [details]
Patch
Comment on attachment 453581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453581&action=review > Source/WebCore/animation/KeyframeEffectStack.cpp:146 > - if (propertyAffectingLogicalPropertiesChanged) > - effect->propertyAffectingLogicalPropertiesDidChange(unanimatedStyle, resolutionContext); > + if (propertyAffectingLogicalPropertiesChanged || fontSizeChanged) > + effect->propertyAffectingKeyframeResolutionDidChange(unanimatedStyle, resolutionContext); This is probably incomplete as various other things can affect unit resolution (like zoom property). (In reply to Antti Koivisto from comment #3) > Comment on attachment 453581 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453581&action=review > > > Source/WebCore/animation/KeyframeEffectStack.cpp:146 > > - if (propertyAffectingLogicalPropertiesChanged) > > - effect->propertyAffectingLogicalPropertiesDidChange(unanimatedStyle, resolutionContext); > > + if (propertyAffectingLogicalPropertiesChanged || fontSizeChanged) > > + effect->propertyAffectingKeyframeResolutionDidChange(unanimatedStyle, resolutionContext); > > This is probably incomplete as various other things can affect unit > resolution (like zoom property). Excellent! Do you know of others? Created attachment 453588 [details]
Patch
> Excellent! Do you know of others?
Stuff that shows up in CSSPrimitiveValue::computeNonCalcLengthDouble and pals I suppose.
Committed r290730 (247977@main): <https://commits.webkit.org/247977@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453588 [details]. |