| Summary: | Move StorageBucket function definitions outside the class definition | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||
| Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, sihui_liu, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sihui Liu
2022-02-28 18:31:27 PST
Created attachment 453466 [details]
Patch
Comment on attachment 453466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453466&action=review r=me > Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:115 > + return ""_s; emptyString() > Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:166 > + return m_localStorageManager.get(); This is a one liner, I think we should keep it inline within the class definition. > Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:179 > + return m_sessionStorageManager.get(); ditto. > Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:192 > + return m_idbStorageManager.get(); ditto. Created attachment 453515 [details]
Patch for landing
Created attachment 453516 [details]
Patch for landing
Committed r290669 (?): <https://commits.webkit.org/r290669> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453516 [details]. |