Bug 237285

Summary: REGRESSION(r290539-r290538): [ iOS ] 3 TestWebKitAPI.WebAuthenticationPanel.* tests are constantly failing/crashing.
Product: WebKit Reporter: Dawn Morningstar <Morningstar>
Component: New BugsAssignee: pascoe <pascoe>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, pascoe, webkit-bot-watchers-bugzilla, webkit-bug-importer, WebkitBugTracker
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=237223
Attachments:
Description Flags
Patch none

Dawn Morningstar
Reported 2022-02-28 13:39:39 PST
TestWebKitAPI.WebAuthenticationPanel.UpdateCredentialUsername TestWebKitAPI.WebAuthenticationPanel.LAMakeCredentialRollBackCredential TestWebKitAPI.WebAuthenticationPanel.LANoCredential Are constantly failing/crashing on iOS. HISTORY: https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebAuthenticationPanel.UpdateCredentialUsername&test=TestWebKitAPI.WebAuthenticationPanel.LAMakeCredentialRollBackCredential&test=TestWebKitAPI.WebAuthenticationPanel.LANoCredential Regression range appears to be r290539-r290538. Related to https://bugs.webkit.org/show_bug.cgi?id=237223
Attachments
Patch (3.34 KB, patch)
2022-02-28 15:13 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dawn Morningstar
Comment 1 2022-02-28 13:42:13 PST
At iOS Debug TOT TestWebKitAPI.WebAuthenticationPanel.UpdateCredentialUsername passes, TestWebKitAPI.WebAuthenticationPanel.LAMakeCredentialRollBackCredential and TestWebKitAPI.WebAuthenticationPanel.LANoCredential provide an ASSERTION FAILED: databaseUpdated error. These results continue even before suspected regression point. Results still the same at r290539 r290538 and r290537.
Radar WebKit Bug Importer
Comment 2 2022-02-28 13:51:15 PST
<rdar://problem/89579460>
pascoe@apple.com
Comment 3 2022-02-28 15:13:33 PST
Created attachment 453440 [details] Patch
pascoe@apple.com
Comment 4 2022-02-28 15:54:49 PST
This is caused by LAMakeCredentialRollBackCredential being obsolete, but still creating a credential before failing, which causes the other two tests to fail / timeout as well.
Brent Fulgham
Comment 5 2022-03-01 08:48:24 PST
Comment on attachment 453440 [details] Patch r=me
EWS
Comment 6 2022-03-01 09:41:46 PST
Committed r290652 (247925@main): <https://commits.webkit.org/247925@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453440 [details].
Note You need to log in before you can comment on or make changes to this bug.