Bug 237269

Summary: allow-custom-protocols-navigation sandbox flag.
Product: WebKit Reporter: Arthur Sonzogni <arthursonzogni>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, darin, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=231727
Bug Depends on:    
Bug Blocks: 237605    
Attachments:
Description Flags
Patch none

Arthur Sonzogni
Reported 2022-02-28 04:42:22 PST
Feature request: https://github.com/whatwg/html/pull/7654 The freshly minted "allow-custom-protocols-navigation" would navigations toward external applications to continue to work inside a sandboxed iframe. This is a follow-up to: https://bugs.webkit.org/show_bug.cgi?id=231727 which has been implemented in Webkit with quirks for microsoft team. Implementing it would allow removing the quirk, once Microsoft Team start using it.
Attachments
Patch (8.37 KB, patch)
2022-03-07 08:52 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-07 04:43:14 PST
<rdar://problem/89899736>
Chris Dumez
Comment 2 2022-03-07 08:52:49 PST
Created attachment 453995 [details] Patch
Geoffrey Garen
Comment 3 2022-03-07 13:34:45 PST
Comment on attachment 453995 [details] Patch r=me
EWS
Comment 4 2022-03-07 14:33:58 PST
Committed r290958 (248140@main): <https://commits.webkit.org/248140@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453995 [details].
Arthur Sonzogni
Comment 5 2022-03-08 01:15:18 PST
Hi Chris, You landed "allow-custom-protocols-navigation". Great! This was the initial name, but it changed to: "allow-top-navigation-to-custom-protocols" This was requested here: https://github.com/whatwg/html/pull/7654#issuecomment-1054219407 You probably want to make a correction to your patch.
Chris Dumez
Comment 6 2022-03-08 07:09:37 PST
(In reply to Arthur Sonzogni from comment #5) > Hi Chris, > > You landed "allow-custom-protocols-navigation". Great! > > This was the initial name, but it changed to: > "allow-top-navigation-to-custom-protocols" > > This was requested here: > https://github.com/whatwg/html/pull/7654#issuecomment-1054219407 > > You probably want to make a correction to your patch. Ouch! Thanks for pointing this out. I'll follow-up.
Chris Dumez
Comment 7 2022-03-08 07:23:28 PST
(In reply to Chris Dumez from comment #6) > (In reply to Arthur Sonzogni from comment #5) > > Hi Chris, > > > > You landed "allow-custom-protocols-navigation". Great! > > > > This was the initial name, but it changed to: > > "allow-top-navigation-to-custom-protocols" > > > > This was requested here: > > https://github.com/whatwg/html/pull/7654#issuecomment-1054219407 > > > > You probably want to make a correction to your patch. > > Ouch! Thanks for pointing this out. I'll follow-up. Following up in Bug 237605.
Note You need to log in before you can comment on or make changes to this bug.