Bug 237267

Summary: Introduce routines to exchange SharedVideoFrame::Buffer directly
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2022-02-27 23:45:18 PST
Introduce routines to exchange SharedVideoFrame::Buffer directly
Attachments
Patch (36.22 KB, patch)
2022-02-27 23:53 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (35.82 KB, patch)
2022-02-28 01:37 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (35.23 KB, patch)
2022-03-01 04:01 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (35.23 KB, patch)
2022-03-01 07:15 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (35.39 KB, patch)
2022-03-03 04:25 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-02-27 23:53:32 PST
Created attachment 453371 [details] Patch
youenn fablet
Comment 2 2022-02-28 01:37:11 PST
Created attachment 453375 [details] Patch
youenn fablet
Comment 3 2022-03-01 04:01:11 PST
Created attachment 453488 [details] Patch
youenn fablet
Comment 4 2022-03-01 07:15:31 PST
Created attachment 453497 [details] Patch
youenn fablet
Comment 5 2022-03-02 06:55:41 PST
Ping review.
Eric Carlson
Comment 6 2022-03-02 08:28:44 PST
Comment on attachment 453497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453497&action=review > Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:109 > + auto videoFrame = get(WTFMove(read)); Obviously this isn't new to this patch, but reading this made me realize that RemoteVideoFrameObjectHeap::get is a confusing name because `get` RefPtr::get and Ref::get are so widely used in WebKit and don't mean the same thing at all. > Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:248 > + m_videoFrameObjectHeap->get(WTFMove(std::get<RemoteVideoFrameReadReference>(sharedVideoFrame.buffer))); Ditto.
youenn fablet
Comment 7 2022-03-03 04:25:14 PST
Created attachment 453718 [details] Patch for landing
EWS
Comment 8 2022-03-04 01:16:17 PST
Committed r290824 (248060@main): <https://commits.webkit.org/248060@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453718 [details].
Radar WebKit Bug Importer
Comment 9 2022-03-04 01:17:19 PST
<rdar://problem/89802729>
Note You need to log in before you can comment on or make changes to this bug.