Bug 237198

Summary: RemoteVideoFrameObjectHeap should process its IPC messages in a background thread
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, hi, jer.noble, joepeck, kkinnunen, pangle, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 237191    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing ews-feeder: commit-queue-

youenn fablet
Reported 2022-02-25 04:25:46 PST
RemoteVideoFrameObjectHeap should process its IPC messages in a background thread
Attachments
Patch (23.09 KB, patch)
2022-02-25 04:40 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (23.09 KB, patch)
2022-02-27 09:02 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (23.96 KB, patch)
2022-02-27 23:13 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-02-25 04:40:42 PST
Created attachment 453196 [details] Patch
Darin Adler
Comment 2 2022-02-25 14:18:05 PST
Comment on attachment 453196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453196&action=review > Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:47 > + static auto& queue = WorkQueue::create("org.webkit.RemoteVideoFrameObjectHeap", WorkQueue::QOS::UserInteractive).leakRef(); > + return queue; In newer code we’ve been using NeverDestroyed rather than leakRef for cases like this. More like this: static NeverDestroyed queue = WorkQueue::create("org.webkit.RemoteVideoFrameObjectHeap", WorkQueue::QOS::UserInteractive; return queue; Should be the same generated code.
youenn fablet
Comment 3 2022-02-27 09:02:10 PST
Created attachment 453343 [details] Patch for landing
youenn fablet
Comment 4 2022-02-27 23:13:34 PST
Created attachment 453369 [details] Patch for landing
EWS
Comment 5 2022-02-28 02:19:44 PST
Committed r290591 (247869@main): <https://commits.webkit.org/247869@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453369 [details].
Radar WebKit Bug Importer
Comment 6 2022-02-28 02:20:21 PST
<rdar://problem/89548682>
Note You need to log in before you can comment on or make changes to this bug.