Bug 237179

Summary: [libpas] Suppress cast-align warnings
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: bmallocAssignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, Basuke.Suzuki, ews-watchlist, ggaren, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
none
PATCH none

Description Basuke Suzuki 2022-02-24 20:21:02 PST 
There are  tons of cast-align warnings while compiling libpas.
Comment 1 Basuke Suzuki 2022-02-24 20:22:58 PST 
Initially I've added -Wno-cast-align compiler flags on bmalloc build, but the headers are also indirectly used in WTF. Disabling that warning in entire WTF doesn't seems a good idea.
Comment 2 Radar WebKit Bug Importer 2022-02-25 09:58:05 PST 
<rdar://problem/89479570>
Comment 3 Basuke Suzuki 2022-02-25 14:23:52 PST 
Created attachment 453262 [details]
PATCH
Comment 4 Basuke Suzuki 2022-02-25 15:15:33 PST 
This patch works, but it's too busy to put the macro into every occurrence. I think it's okay to put the macro to wrap entire code except the one in the macro usage. I believe libpas is carefully written for the situation this warning describes.
Comment 5 Basuke Suzuki 2022-02-25 17:20:54 PST 
Created attachment 453280 [details]
PATCH
Comment 6 Basuke Suzuki 2022-02-25 17:22:00 PST 
After discussing with Yusuke, I've decided to follow the treatment of `missing-field-initializers` warning.
Comment 7 Yusuke Suzuki 2022-02-25 17:40:53 PST 
Comment on attachment 453280 [details]
PATCH

r=me
Comment 8 EWS 2022-02-25 20:00:46 PST 
Committed r290541 (247819@main): <https://commits.webkit.org/247819@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453280 [details].