| Summary: | Begin transition from WTF::Span to std::span | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aboxhall, alecflett, andresg_22, apinheiro, beidson, benjamin, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, ddkilzer, dino, dmazzoni, don.olmstead, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, hta, japhet, jcraig, jdiggs, jer.noble, jsbell, kondapallykalyan, mifenton, pdr, philipj, ross.kirsling, sabouhallawa, samuel_white, schenney, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 253377 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2022-02-24 19:55:48 PST
Created attachment 453169 [details]
Patch
Comment on attachment 453169 [details]
Patch
Apparently Visual Studio 2019's C++20 implementation doesn't have the span header.
Created attachment 458160 [details]
Patch
Created attachment 458551 [details]
Patch with explicit conversions
Here's an updated patch that builds on Windows.
Created attachment 458558 [details]
Patch
Comment on attachment 458558 [details]
Patch
Looks like std::span requires GCC 10. Bummer.
(In reply to Alex Christensen from comment #7) > Comment on attachment 458558 [details] > Patch > > Looks like std::span requires GCC 10. Bummer. Can you do a check for it in CMake for std::span and if its there use it otherwise use our implementation of std::span? I guess we will have to wait another year for this, but my goal is to remove WTF::Span. Bug 253377 started using std::span for all Apple ports (including any port compiling with clang or MSVC, plus ports that compile with GCC that pass a compile test in CMake) behind a WTF::makeSpan() adapter. Once all ports support std::span, the WTF::makeSpan() adapter will be removed. Just for the record, it's not just GCC; PS port needed a fix too: https://github.com/WebKit/WebKit/commit/f105d6117bd798d28c016d2f2a639e693afbeefa Pull request: https://github.com/WebKit/WebKit/pull/13414 Committed 263998@main (0fa955e615eb): <https://commits.webkit.org/263998@main> Reviewed commits have been landed. Closing PR #13414 and removing active labels. |