Bug 237168

Summary:

Change one-shot maxTimerNestingLevel from 5 to 10

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+, ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Description Yusuke Suzuki 2022-02-24 16:28:54 PST

Change maxTimerNestingLevel from 5 to 10

Comment 1 Yusuke Suzuki 2022-02-24 16:32:24 PST

Created attachment 453155 [details]
Patch

Comment 2 Sam Weinig 2022-02-28 08:22:49 PST

Comment on attachment 453155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453155&action=review

> Source/WebCore/ChangeLog:10
> +
> +        Recently, we found from Chromium change[1] that changing this from 5 to 10 offers 10% Speedometer2 improvement
> +        because Speedometer2's setTimeout nesting level is typically 7-8. We discussed with folks including Chris, Maciej,
> +        Saam, and Cameron and now we increase this from 5 to 10 to align to Blink's change to keep these kind of web content fast.

Does the HTML spec say anything here? Perhaps it should? Probably at least worth filing an issue.

Comment 3 Radar WebKit Bug Importer 2022-03-03 16:29:16 PST

<rdar://problem/89784131>

Comment 4 Yusuke Suzuki 2022-03-31 16:49:09 PDT

Created attachment 456295 [details]
Patch

Comment 5 Yusuke Suzuki 2022-04-01 11:45:42 PDT

Created attachment 456380 [details]
Patch

Comment 6 Yusuke Suzuki 2022-04-01 15:19:10 PDT

mac-wk1 and mac-wk2 bots are getting stuck.

Comment 7 Yusuke Suzuki 2022-04-01 16:57:50 PDT

Committed r292242 (249140@trunk): <https://commits.webkit.org/249140@trunk>