| Summary: | [iOS] Add support for replacing WKFoundTextRanges | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||
| Component: | New Bugs | Assignee: | Aditya Keerthi <akeerthi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | hi, katherine_cheney, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aditya Keerthi
2022-02-24 12:18:56 PST
Created attachment 453124 [details]
Patch
Comment on attachment 453124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453124&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10432 > + return self.webView._editable; It's a tiny bit surprising that this is only for Mail compose. I suppose that's because there's no per-text-range notion of editability baked into the API yet? (In reply to Wenson Hsieh from comment #3) > Comment on attachment 453124 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453124&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10432 > > + return self.webView._editable; > > It's a tiny bit surprising that this is only for Mail compose. I suppose > that's because there's no per-text-range notion of editability baked into > the API yet? Thanks for the review! Per-text-range editability is still under discussion (there is partial support). This patch addresses the simpler, higher value replacement scenario. Committed r290481 (247777@main): <https://commits.webkit.org/247777@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453124 [details]. |