Bug 23714
| Summary: | void CSSStyleDeclaration::diff(CSSMutableStyleDeclaration* style) const is poorly named and backwards! | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, hyatt, justin.garcia, rniwa, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
void CSSStyleDeclaration::diff(CSSMutableStyleDeclaration* style) const is poorly named and backwards!
It really should be something like "removePropertiesMatching(CSSMutableStyleDeclaration*)" or similar.
I ran across this while trying to fix font-decoration toggling execCommands.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
CSSMutableStyleDeclaration - only has one hit in Webkit source code on Github and it is in unit test python file and I think this bug was fixed some time back and renamed.
https://github.com/WebKit/WebKit/blob/8afe31a018b11741abdf9b4d5bb973d7c1d9ff05/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py#L296
I think this can be closed now. Thanks!
Alexey Proskuryakov
This is about CSSStyleDeclaration::diff, not about CSSMutableStyleDeclaration. But either way, there isn't such function any more.