Bug 237124

Summary: [GTK] Unreviewed, fix build after r290399
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED INVALID    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq] Patch none

Diego Pino
Reported 2022-02-23 17:29:40 PST
[GTK] Unreviewed, fix build after r290399
Attachments
[fast-cq] Patch (1.62 KB, patch)
2022-02-23 17:31 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2022-02-23 17:31:40 PST
Created attachment 453057 [details] [fast-cq] Patch
Diego Pino
Comment 2 2022-02-23 17:35:12 PST
STDIO: https://build.webkit.org/#/builders/41/builds/9656/steps/9/logs/stdio /app/webkit/Source/WebCore/page/DOMWindow.cpp: In member function ‘void WebCore::DOMWindow::showModalDialog(const WTF::String&, const WTF::String&, WebCore::DOMWindow&, WebCore::DOMWindow&, const WTF::Function<void(WebCore::DOMWindow&)>&)’: /app/webkit/Source/WebCore/page/DOMWindow.cpp:2672:5: error: ‘printWarningMessage’ was not declared in this scope; did you mean ‘printErrorMessage’? 2672 | printWarningMessage("showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead."_s); | ^~~~~~~~~~~~~~~~~~~ | printErrorMessage
Diego Pino
Comment 3 2022-02-23 17:35:43 PST
Fixed by https://trac.webkit.org/changeset/290406/webkit
Note You need to log in before you can comment on or make changes to this bug.