| Summary: | [IFC][Integration] LineLayout::firstLinePhysicalBaseline/lastLineLogicalBaseline should flip box baseline value for vertical-lr | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2022-02-23 09:38:18 PST
Created attachment 452992 [details]
Patch
Comment on attachment 452992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452992&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:466 > + switch (rootLayoutBox().style().writingMode()) { > + case WritingMode::TopToBottom: wonder if the switch could be usefully shared between first/last cases? (In reply to Antti Koivisto from comment #2) > Comment on attachment 452992 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452992&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:466 > > + switch (rootLayoutBox().style().writingMode()) { > > + case WritingMode::TopToBottom: > > wonder if the switch could be usefully shared between first/last cases? I'd rather not mix logical and physical translates (the first baseline API returns physical while the last baseline API returns logical baseline value) Committed r290388 (247703@main): <https://commits.webkit.org/247703@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452992 [details]. |