Bug 237042

Summary: fast/mediastream/getUserMedia-to-canvas-1.html and fast/mediastream/getUserMedia-to-canvas-2.html are failing on MacOS when remote video frame flag is enabled
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric.carlson, ews-watchlist, glenn, hta, jenner, jer.noble, kkinnunen, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=237392
Bug Depends on:    
Bug Blocks: 237201    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Description youenn fablet 2022-02-22 09:22:56 PST 
See https://ews-build.webkit.org/#/builders/60/builds/24471.
On the bots, this is happening on MacOS with webrtc remote frame turned on and WebGL GPUProcess turned off.
Comment 1 Radar WebKit Bug Importer 2022-02-22 09:24:08 PST 
<rdar://problem/89298601>
Comment 2 youenn fablet 2022-03-01 02:44:47 PST 
Created attachment 453481 [details]
Patch
Comment 3 Eric Carlson 2022-03-01 09:21:13 PST 
Comment on attachment 453481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453481&action=review

> LayoutTests/ChangeLog:3
> +        fast/mediastream/getUserMedia-to-canvas-1.html and fast/mediastream/getUserMedia-to-canvas-2.html are failing on MacOS when remote video frame flag is enabled

Nit: It would be nice to wrap the very long lines in this ChangeLog so they are easier to read on a small screen

> LayoutTests/ChangeLog:9
> +        Video element videoWidth/videoHeight are updated when track settings are changed, and not according video frames being received.

s/not according video frames being/not when video frames are/
Comment 4 youenn fablet 2022-03-01 09:36:29 PST 
Created attachment 453506 [details]
Patch for landing
Comment 5 EWS 2022-03-01 10:36:21 PST 
Committed r290658 (247930@main): <https://commits.webkit.org/247930@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453506 [details].
Comment 6 Robert Jenner 2022-03-02 18:44:57 PST 
Reverted r290658 for reason:

r290658 broke two tests for iOS, slowing down EWS.

Committed r290763 (248007@trunk): <https://commits.webkit.org/248007@trunk>
Comment 7 youenn fablet 2022-03-03 00:59:23 PST 
Created attachment 453707 [details]
Patch
Comment 8 EWS 2022-03-03 23:56:28 PST 
Committed r290819 (248055@main): <https://commits.webkit.org/248055@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453707 [details].