Bug 237030

Summary: [JSC] Make runner should only schedule tests on live remotes
Product: WebKit Reporter: Angelos Oikonomopoulos <angelos>
Component: New BugsAssignee: Angelos Oikonomopoulos <angelos>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, Hironori.Fujii, jbedard, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Angelos Oikonomopoulos
Reported 2022-02-22 03:46:59 PST
[JSC] Make runner should only schedule tests on live remotes
Attachments
Patch (10.54 KB, patch)
2022-02-22 03:48 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (10.65 KB, patch)
2022-03-09 03:53 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2022-02-22 03:48:30 PST
Created attachment 452851 [details] Patch
Radar WebKit Bug Importer
Comment 2 2022-03-01 03:47:16 PST
<rdar://problem/89611629>
Adrian Perez
Comment 3 2022-03-08 02:24:56 PST
Comment on attachment 452851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452851&action=review > Tools/Scripts/run-jsc-stress-tests:2584 > + "sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null" I remember we chatted about using “getconf _NPROCESSORS_ONLN” here as one last resort option, so you might want to add that before landing. Nevertheless, given that it's not currently needed for the runners where this has to work, feel free to land the patch as-is.
Angelos Oikonomopoulos
Comment 4 2022-03-09 03:53:38 PST
Created attachment 454222 [details] Patch
Angelos Oikonomopoulos
Comment 5 2022-03-09 03:55:34 PST
(In reply to Adrian Perez from comment #3) > Comment on attachment 452851 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452851&action=review > > > Tools/Scripts/run-jsc-stress-tests:2584 > > + "sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null" > > I remember we chatted about using “getconf _NPROCESSORS_ONLN” here as one > last > resort option, so you might want to add that before landing. Nevertheless, > given > that it's not currently needed for the runners where this has to work, feel > free > to land the patch as-is. Yup. This patch predates our discussion re: getconf. Uploaded a new version that uses it if all else has failed.
EWS
Comment 6 2022-03-09 05:32:17 PST
Committed r291045 (248219@main): <https://commits.webkit.org/248219@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454222 [details].
Note You need to log in before you can comment on or make changes to this bug.