| Summary: | [JSC] Make runner should only schedule tests on live remotes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||||
| Component: | New Bugs | Assignee: | Angelos Oikonomopoulos <angelos> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aperez, Hironori.Fujii, jbedard, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Angelos Oikonomopoulos
2022-02-22 03:46:59 PST
Created attachment 452851 [details]
Patch
Comment on attachment 452851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452851&action=review > Tools/Scripts/run-jsc-stress-tests:2584 > + "sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null" I remember we chatted about using “getconf _NPROCESSORS_ONLN” here as one last resort option, so you might want to add that before landing. Nevertheless, given that it's not currently needed for the runners where this has to work, feel free to land the patch as-is. Created attachment 454222 [details]
Patch
(In reply to Adrian Perez from comment #3) > Comment on attachment 452851 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452851&action=review > > > Tools/Scripts/run-jsc-stress-tests:2584 > > + "sysctl -n hw.activecpu 2>/dev/null || nproc --all 2>/dev/null" > > I remember we chatted about using “getconf _NPROCESSORS_ONLN” here as one > last > resort option, so you might want to add that before landing. Nevertheless, > given > that it's not currently needed for the runners where this has to work, feel > free > to land the patch as-is. Yup. This patch predates our discussion re: getconf. Uploaded a new version that uses it if all else has failed. Committed r291045 (248219@main): <https://commits.webkit.org/248219@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454222 [details]. |