Summary: | Thread safety analysis macros are confusing for non-Lock use-cases | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||
Component: | Web Template Framework | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dino, eric.carlson, ews-watchlist, glenn, jbedard, jean-yves.avenard, jer.noble, philipj, rniwa, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 236832 | ||||||||
Attachments: |
|
Description
Kimmo Kinnunen
2022-02-22 00:09:38 PST
Created attachment 452838 [details]
Patch
Created attachment 452855 [details]
Option B without the renames
Comment on attachment 452855 [details]
Option B without the renames
r=me
Comment on attachment 452838 [details]
Patch
Removing the r? flag from the first patch.
Stopped https://ews-build.webkit.org/#/builders/70/builds/1025, the 3 failures it flagged are already known. The 3 failures flagged by https://ews-build.webkit.org/#/builders/70/builds/1025 are already known, so I stopped the build. Committed r290361 (247679@main): <https://commits.webkit.org/247679@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452855 [details]. |