Bug 236998 – NSSharingServicePicker gets deallocated when using the standard share menu item

• Component: New Bugs
• Status: RESOLVED FIXED

[Kate Cheney]

NSSharingServicePicker gets deallocated when using the standard share menu item

[Kate Cheney]

Created attachment 452782 [details]
Patch

[Kate Cheney]

rdar://89174827

[Wenson Hsieh]

Comment on attachment 452782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452782&action=review

> Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:419
> +        [shareMenuItem setRepresentedObject:sharingServicePicker.get()];

Do we need to also unset this at some point in time? (Or does it clean up when the menu is done presenting?)

[Kate Cheney]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 452782 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452782&action=review
> 
> > Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:419
> > +        [shareMenuItem setRepresentedObject:sharingServicePicker.get()];
> 
> Do we need to also unset this at some point in time? (Or does it clean up
> when the menu is done presenting?)

We should not need to unset it, AFAICT we only use it to keep the picker alive as long as the NSMenuItem is alive.

[EWS]

Committed r290292 (247616@main): <https://commits.webkit.org/247616@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452782 [details].