[WebGPU] Tracer bullet part 10: Implement setLabel() and Metal accessors

• Component: WebGPU
• Status: RESOLVED FIXED

[Myles C. Maxfield]

By adding a few various trivial functions in classes that need them, this patch completely finishes the implementation of CommandBuffer, QuerySet, RenderBundle, Sampler, and TextureView classes (other than their creation functions).

[Myles C. Maxfield]

Created attachment 452678 [details]
Patch

[Dean Jackson]

Comment on attachment 452678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452678&action=review

> Source/WebGPU/WebGPU/RenderPassEncoder.mm:178
> +    m_renderCommandEncoder.label = [NSString stringWithCString:label encoding:NSUTF8StringEncoding];

Do you ever want to ASSERT that m_renderCommandEncoder etc exist?

[Myles C. Maxfield]

Comment on attachment 452678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452678&action=review

>> Source/WebGPU/WebGPU/RenderPassEncoder.mm:178
>> +    m_renderCommandEncoder.label = [NSString stringWithCString:label encoding:NSUTF8StringEncoding];
> 
> Do you ever want to ASSERT that m_renderCommandEncoder etc exist?

Yep! It's done in the creation routines. And rather than ASSERT()ing, it instead just doesn't create the WebGPU wrapper object.

[Myles C. Maxfield]

Committed r290266 (247591@trunk): <https://commits.webkit.org/247591@trunk>

[Radar WebKit Bug Importer]

<rdar://problem/89253939>