Bug 236909

Summary:

[GPU Process] [iOS] Text decoration is always drawn with solid stroke style

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

WebKit Process Model

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mmaxfield, sabouhallawa, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

233914, 236508

Attachments:

Description	Flags
Patch	simon.fraser: review+
Patch	none

Description Jon Lee 2022-02-19 21:39:21 PST

fast/css3-text/css3-text-decoration/text-decoration-dashed.html [ ImageOnlyFailure ]
fast/css3-text/css3-text-decoration/text-decoration-dotted-dashed.html [ ImageOnlyFailure ]
fast/css3-text/css3-text-decoration/text-decoration-dotted.html [ ImageOnlyFailure ]
fast/css3-text/css3-text-decoration/text-underline-style.html [ ImageOnlyFailure ]

Comment 1 Radar WebKit Bug Importer 2022-02-19 21:39:58 PST

<rdar://problem/89196615>

Comment 2 Said Abou-Hallawa 2022-03-31 14:01:41 PDT

Created attachment 456277 [details]
Patch

Comment 3 Simon Fraser (smfr) 2022-03-31 14:10:22 PDT

Comment on attachment 456277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456277&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:937
> +    StrokeStyle m_style;

This is currently 4 bytes. Might as well change `enum StrokeStyle` to `enum StrokeStyle : uint8_t` while you're at it.

Comment 4 Said Abou-Hallawa 2022-03-31 14:35:48 PDT

Created attachment 456283 [details]
Patch

Comment 5 EWS 2022-03-31 17:29:55 PDT

Committed r292190 (249093@main): <https://commits.webkit.org/249093@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456283 [details].