Bug 236903

Summary: [WebGPU] Tracer bullet part 9: Basic implementation of bindings
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 236879    
Attachments:
Description Flags
Patch
none
Patch
none
Patch dino: review+

Myles C. Maxfield
Reported 2022-02-19 20:59:22 PST
This is a basic implementation of the BindGroup, BindGroupLayout, and PipelineLayout methods. Eventually we'll want to suballocate multiple BindGroups so they coexist within the same Buffer, but this is an initial simple implementation that doesn't do that.
Attachments
Patch (22.31 KB, patch)
2022-02-19 21:00 PST, Myles C. Maxfield
no flags
Patch (22.31 KB, text/plain)
2022-02-19 21:04 PST, Myles C. Maxfield
no flags
Patch (22.32 KB, patch)
2022-02-19 21:09 PST, Myles C. Maxfield
dino: review+
Myles C. Maxfield
Comment 1 2022-02-19 21:00:48 PST
Myles C. Maxfield
Comment 2 2022-02-19 21:04:11 PST
Myles C. Maxfield
Comment 3 2022-02-19 21:09:23 PST
Dean Jackson
Comment 4 2022-02-21 09:33:34 PST
Comment on attachment 452675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452675&action=review > Source/WebGPU/WebGPU/BindGroup.h:48 > + id <MTLBuffer> vertexArgumentBuffer() const { return m_vertexArgumentBuffer; } > + id <MTLBuffer> fragmentArgumentBuffer() const { return m_fragmentArgumentBuffer; } > + id <MTLBuffer> computeArgumentBuffer() const { return m_computeArgumentBuffer; } id<MTLBuffer> no space. Here and elsewhere.
Myles C. Maxfield
Comment 5 2022-02-21 13:28:01 PST
Myles C. Maxfield
Comment 6 2022-02-21 13:28:05 PST
Comment on attachment 452675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452675&action=review >> Source/WebGPU/WebGPU/BindGroup.h:48 >> + id <MTLBuffer> computeArgumentBuffer() const { return m_computeArgumentBuffer; } > > id<MTLBuffer> no space. Here and elsewhere. I sent an email to webkit-dev about this. Let's see what people say, and then I'll add a rule to the style guide about it.
Radar WebKit Bug Importer
Comment 7 2022-02-21 13:28:18 PST
Note You need to log in before you can comment on or make changes to this bug.