Summary: | QtWebKit needs a DOM API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Genevieve Mak <gen> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | hausmann, manyoso, mike, staikos, victor.grishchenko | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Genevieve Mak
2009-02-02 12:27:17 PST
Correction, the proposal is for a QtWebKit specific DOM API :) Created attachment 27255 [details] Initial version of DOM API Initial version of DOM API originally started here: http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commit;h=12f59ec1506a3c7e85fb57b922afea0866df65e1 With modifications from Genevieve Mak to eliminate dependency on Qt4.5*. Adding Simon into the mix :) Add George too :) Comment on attachment 27255 [details]
Initial version of DOM API
I would prefer for this code to be developed in a Git branch first before hitting the SVN trunk.
The patch itself has a couple of coding style problems (for example the brace for function definitions belongs onto a line of its own) and it would be good not to have comments like "// end of stuff added buy gen" in the code itself.
Instead it should be a separate patch, to recognize the contribution by a different author.
That said, let's use this forum or email to discuss the API :).
I'm ok with having it in a separate git branch for the moment. Should we go ahead and apply these changes - minus the stray comments - to this branch then? http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=shortlog;h=shared/new-dom-api Cheers, Adam Sounds good to me. Would you guys have time for a workshop in March or April perhaps? It would be fun to work out this stuff in a face-to-face meeting. Are you thinking of taking a trip across the pond or rather for us to meet you guys in Oslo? :) *** Bug 16959 has been marked as a duplicate of this bug. *** We have done some progress on this topic in the shared/dom-api-sprint branch, rebased to recent master: http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=shortlog;h=shared/dom-api-sprint We hope to land an initial version - without any API guarantees and subject to change - in the trunk soon, in order to get some feedback. Closing this bug as after an intensive sprint last week we just submitted a first draft API into the trunk in r42238. Let's do more reviews and polishing in the trunk :) BTW, the docs are still marked with \preliminary, indicating the status of not being finalized. |