Bug 23690 - QtWebKit needs a DOM API
Summary: QtWebKit needs a DOM API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
: 16959 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-02-02 12:27 PST by Genevieve Mak
Modified: 2009-04-06 04:29 PDT (History)
5 users (show)

See Also:


Attachments
Initial version of DOM API (12.45 KB, patch)
2009-02-02 12:55 PST, Adam Treat
hausmann: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Genevieve Mak 2009-02-02 12:27:17 PST
Webkit needs an accessable DOM API so that the browser can implement special features such as accessability features based on the contents of the page loaded.
Comment 1 Adam Treat 2009-02-02 12:33:46 PST
Correction, the proposal is for a QtWebKit specific DOM API :)
Comment 2 Adam Treat 2009-02-02 12:55:12 PST
Created attachment 27255 [details]
Initial version of DOM API

Initial version of DOM API originally started here:

http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commit;h=12f59ec1506a3c7e85fb57b922afea0866df65e1

With modifications from Genevieve Mak to eliminate dependency on Qt4.5*.
Comment 3 Adam Treat 2009-02-02 12:59:14 PST
Adding Simon into the mix :)
Comment 4 Adam Treat 2009-02-02 13:01:10 PST
Add George too :)
Comment 5 Simon Hausmann 2009-02-03 05:14:42 PST
Comment on attachment 27255 [details]
Initial version of DOM API

I would prefer for this code to be developed in a Git branch first before hitting the SVN trunk.

The patch itself has a couple of coding style problems (for example the brace for function definitions belongs onto a line of its own) and it would be good not to have comments like "// end of stuff added buy gen" in the code itself.

Instead it should be a separate patch, to recognize the contribution by a different author.

That said, let's use this forum or email to discuss the API :).
Comment 6 Adam Treat 2009-02-03 08:00:31 PST
I'm ok with having it in a separate git branch for the moment.  Should we go ahead and apply these changes - minus the stray comments - to this branch then?

http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=shortlog;h=shared/new-dom-api

Cheers,
Adam
Comment 7 Simon Hausmann 2009-02-03 09:07:16 PST
Sounds good to me. Would you guys have time for a workshop in March or April perhaps? It would be fun to work out this stuff in a face-to-face meeting.
Comment 8 Adam Treat 2009-02-03 09:13:44 PST
Are you thinking of taking a trip across the pond or rather for us to meet you guys in Oslo? :)
Comment 9 Adam Treat 2009-02-23 09:07:54 PST
*** Bug 16959 has been marked as a duplicate of this bug. ***
Comment 10 Simon Hausmann 2009-04-01 08:36:08 PDT
We have done some progress on this topic in the shared/dom-api-sprint branch, rebased to recent master:

http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=shortlog;h=shared/dom-api-sprint

We hope to land an initial version - without any API guarantees and subject to change - in the trunk soon, in order to get some feedback.
Comment 11 Simon Hausmann 2009-04-06 04:27:48 PDT
Closing this bug as after an intensive sprint last week we just submitted a first draft API into the trunk in r42238. Let's do more reviews and polishing in the trunk :)
Comment 12 Simon Hausmann 2009-04-06 04:29:25 PDT
BTW, the docs are still marked with \preliminary, indicating the status of not being finalized.