Bug 236898

Summary: [WebGPU] Tracer bullet part 5: Give Metal objects to WebGPU objects
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 236891    
Bug Blocks: 236879    
Attachments:
Description Flags
Patch
none
Patch dino: review+

Myles C. Maxfield
Reported 2022-02-19 16:24:06 PST
Each WebGPU object gets its own backing Metal object.
Attachments
Patch (38.24 KB, patch)
2022-02-19 16:26 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (38.36 KB, patch)
2022-02-19 20:17 PST, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-02-19 16:26:13 PST
Created attachment 452662 [details] Patch
Myles C. Maxfield
Comment 2 2022-02-19 20:17:39 PST
Created attachment 452667 [details] Patch
Dean Jackson
Comment 3 2022-02-21 09:23:50 PST
Comment on attachment 452667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452667&action=review > Source/WebGPU/WebGPU/BindGroup.h:53 > + id <MTLBuffer> m_vertexArgumentBuffer { nil }; > + id <MTLBuffer> m_fragmentArgumentBuffer { nil }; > + id <MTLBuffer> m_computeArgumentBuffer { nil }; > }; I think we do id<MTLBuffer> (without the space), here and elsewhere.
Myles C. Maxfield
Comment 4 2022-02-21 11:28:50 PST
Comment on attachment 452667 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452667&action=review >> Source/WebGPU/WebGPU/BindGroup.h:53 >> }; > > I think we do id<MTLBuffer> (without the space), here and elsewhere. I polled the Apple L&R team internally and they seemed to prefer id <MTLBuffer>, so that's what I went with :/
Myles C. Maxfield
Comment 5 2022-02-21 11:32:41 PST
Committed r290256 (?): <https://commits.webkit.org/r290256>
Radar WebKit Bug Importer
Comment 6 2022-02-21 11:33:18 PST
<rdar://problem/89247804>
Note You need to log in before you can comment on or make changes to this bug.