Bug 236823

Summary: Use async NSSharingServicePicker menu if available
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, dino, hi, megan_gardner, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Kate Cheney 2022-02-17 21:06:05 PST 
Use async sharingServicePicker menu if available
Comment 1 Kate Cheney 2022-02-17 21:08:41 PST 
Created attachment 452477 [details]
Patch
Comment 2 Kate Cheney 2022-02-17 21:13:43 PST 
rdar://88858606
Comment 3 Dean Jackson 2022-02-18 08:41:11 PST 
Comment on attachment 452477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452477&action=review

> Source/WebKit/UIProcess/Cocoa/WKShareSheet.h:45
> +- (void)showPickerAsync:(NSSharingServicePicker *)picker showRelativeToRect:(NSRect)presentationRect ofView:(WKWebView *)webView completion:(void (^)(void))completionHandler;
>  @property (nonatomic, weak) id <WKShareSheetDelegate> delegate;

Nit: I think we usually put a blank line between the methods and the @property(s).
Comment 4 Dean Jackson 2022-02-18 08:42:14 PST 
Comment on attachment 452477 [details]
Patch

It seems NSSharingServicePicker is an unknown type.
Comment 5 Kate Cheney 2022-02-18 09:19:31 PST 
(In reply to Dean Jackson from comment #4)
> Comment on attachment 452477 [details]
> Patch
> 
> It seems NSSharingServicePicker is an unknown type.

Oops, I think the SPI is Mac only, need to add some #if PLATFORM(MAC) tags. And then mac failures are because I changed the function but didn't update the non-internal-sdk declarations. New patch coming
Comment 6 Kate Cheney 2022-02-18 09:19:40 PST 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 452477 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452477&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WKShareSheet.h:45
> > +- (void)showPickerAsync:(NSSharingServicePicker *)picker showRelativeToRect:(NSRect)presentationRect ofView:(WKWebView *)webView completion:(void (^)(void))completionHandler;
> >  @property (nonatomic, weak) id <WKShareSheetDelegate> delegate;
> 
> Nit: I think we usually put a blank line between the methods and the
> @property(s).

Will fix in new patch!
Comment 7 Kate Cheney 2022-02-18 09:43:43 PST 
Created attachment 452530 [details]
Patch
Comment 8 Kate Cheney 2022-02-18 09:57:51 PST 
Created attachment 452533 [details]
Patch
Comment 9 EWS 2022-02-18 14:41:50 PST 
Committed r290173 (247504@main): <https://commits.webkit.org/247504@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452533 [details].