Bug 236770

Summary: [GTK] Build broken with ENABLE_X11_TARGET=OFF and no X11 headers present
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, annulen, aperez, cgarcia, clopez, clord, dino, don.olmstead, ews-watchlist, gyuyoung.kim, kbr, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adrian Perez
Reported 2022-02-17 04:22:36 PST
In file included from ../Source/ThirdParty/ANGLE/include/EGL/egl.h:39, from ../Source/ThirdParty/ANGLE/src/common/PackedEGLEnums_autogen.h, from ../Source/ThirdParty/ANGLE/src/common/PackedEnums.h:12, from ../Source/ThirdParty/ANGLE/src/common/PackedEnums.cpp:9: ../Source/ThirdParty/ANGLE/include/EGL/eglplatform.h:128:10: fatal error: X11/Xlib.h: No such file or directory 128 | #include <X11/Xlib.h> | ^~~~~~~~~~~~
Attachments
Patch (1.95 KB, patch)
2022-02-17 04:37 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.01 KB, patch)
2022-02-17 07:12 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2022-02-17 04:24:24 PST
There's the same issue in the 2.34.x releases, tested with the current state of the stable release branch.
Adrian Perez
Comment 2 2022-02-17 04:37:29 PST
Created attachment 452350 [details] Patch
EWS Watchlist
Comment 3 2022-02-17 04:39:21 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Alejandro G. Castro
Comment 4 2022-02-17 04:55:58 PST
Comment on attachment 452350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452350&action=review LGTM! Thanks! > Source/ThirdParty/ANGLE/ChangeLog:8 > + * PlatformGTK.cmake: The USE_SYSTEM_EGL definition makes detaches the type definitions I guess 'makes' is a leftover.
Adrian Perez
Comment 5 2022-02-17 05:01:35 PST
(In reply to Alejandro G. Castro from comment #4) > Comment on attachment 452350 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452350&action=review > > LGTM! Thanks! > > > Source/ThirdParty/ANGLE/ChangeLog:8 > > + * PlatformGTK.cmake: The USE_SYSTEM_EGL definition makes detaches the type definitions > > I guess 'makes' is a leftover. Indeed it's a grammar mistake. I'll fix this before landing the patch, thanks!
Adrian Perez
Comment 6 2022-02-17 07:12:08 PST
Created attachment 452363 [details] Patch for landing
EWS
Comment 7 2022-02-17 09:19:24 PST
Committed r290027 (247407@main): <https://commits.webkit.org/247407@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452363 [details].
Radar WebKit Bug Importer
Comment 8 2022-02-17 09:20:18 PST
<rdar://problem/89090769>
Note You need to log in before you can comment on or make changes to this bug.